iOS Delivery Method Updates and a couple of docs enhancements #377
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Functionality
format
tojson
inlib/noticed/delivery_methods/ios.rb
json
to respond to a symbol as a method inios.rb
Documentation
Description
Changes
format
tojson
inlib/noticed/delivery_methods/ios.rb
The UPGRADE.md lists one of the changes being format option for both iOS and FCM being renamed to JSON. This change had only been implemented for FCM. I'm not certain the approach I've taken here is the right one, it might be better to keep the code as-is and revert the change in the docs. It depends what the original intent was.
Allows
json
to respond to a symbol as a method inios.rb
This change is
lib/noticed/delivery_methods/ios.rb#L36
and adds:Using the same method as
evaluate_options()
in the DeliveryMethod class. It evaluates themethod
if it's a symbol and event responds to that method.Note: I think a similar change might be needed in fcm.rb, but the execution logic in
send_notification(device_token)
is different and I can't get it working.Allows connection_pool_options to respond to symbol representing a method
Similar to the change above, but using the
evaluate_options()
method to allow extraction of values to methodsTesting
All tests pass.
Checklist
Note: This is my first open source code PR. Happy to take on any and all feedback!